Return the negative index position if not found. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it possible to insert the value at correct position. Add Example2 to show how to do this
After some tests -> updated the code
|
After some tests, had to update the code |
tdelmas
reviewed
Feb 28, 2020
| @@ -21,7 +21,7 @@ function compileSearch(funcName, predicate, reversed, extraArgs, earlyOut) { | |||
| } | |||
| code.push("}") | |||
| if(earlyOut) { | |||
| code.push("return -m - 1};") | |||
| code.push("return -l - 1};") | |||
There was a problem hiding this comment.
return -1 -1 is just return 0, looks like a bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible to insert the value at correct position.
Add Example2 to show how to do this