stickyPointerLock typos fix
#8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikolalysenko
added a commit
that referenced
this pull request
Oct 12, 2015
`stickyPointerLock` typos fix
|
Thanks! |
deathcap
added a commit
to voxel/voxel-engine-stackgl
that referenced
this pull request
Dec 31, 2015
If pointerLock is enabled, then also enable stickyPointerLock, in order to continuously re-acquire pointer lock. This is needed to re-acquire after pointer lock is released, but if undesirable behavior this default can be overridden with the stickyPointerLock option to voxel-engine-stackgl. Setting this option fixes a regression - previously (circa 2015/4) it was not needed, but now it is required for correct behavior or you cannot "re-enter" the game after exiting (relinquishing pointer lock with Esc). See: voxel/voxelmetaverse#65 Pointer lock cannot be re-acquired after releasing mikolalysenko/game-shell#8 `stickyPointerLock` typos fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This fixes several presumed typos - the
stickyPointerLockproperty getting spelled other ways, and getting initialized to!options.stickyrather than!!options.sticky.Cheers!