Clean SWIG bindings + add doc #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 23, 2016 12:33
* Can be used in bindings. * The methods is not called in the library.
cchampet
force-pushed
the
dev_cleanSWIGBindings
branch
2 times, most recently
from
221d439 to
f4da9e2
Compare
added 3 commits
May 23, 2016 16:32
To keep symmetry with getFirstFilename method.
cchampet
force-pushed
the
dev_cleanSWIGBindings
branch
from
f4da9e2 to
341cec0
Compare
| @@ -127,6 +129,7 @@ class Sequence | |||
|
|
|||
| inline std::string getSuffix() const; | |||
|
|
|||
| #ifndef SWIG | |||
There was a problem hiding this comment.
Why do you want to remove this function from the binding?
There was a problem hiding this comment.
Found a way to integrate this method to the SWIG interfaces: 66e7002
added 9 commits
May 24, 2016 14:28
Renamed operators in bindings.
The compilation will failed if SWIG has warnings when generate bindings.
Separate methods from attributes, even if both are public.
added 3 commits
May 24, 2016 14:34
Instead of redefine them in Python, and ignore them in Java.
Instead of redefine them in Python, and ignore them in Java.
To understand that Time = Frame.
cchampet
force-pushed
the
dev_cleanSWIGBindings
branch
from
cb6ba7e to
f523753
Compare
cchampet
changed the title
|
@fabiencastan Ready to be merged ;) |
added 5 commits
August 1, 2016 12:13
* Instanciate tempate type "TimePair". * Updated SWIG type "Time" to match C++ type (fixed the following SWIG error: "cannot convert ‘std::pair<int, int>*’ to ‘std::pair<long int, long int>*’ in assignment").
* Need to appy typemaps to handle output parameters. * Need to define a custom typemap for std::string.
* Initialize the output arguments. * Needed when calling this method from a SWIG interface.
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.