Fixing bug : Check item type when found folder sequence #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchampet
reviewed
Nov 7, 2016
| @@ -30,6 +30,7 @@ def setUp(): | |||
|
|
|||
| # create sym link | |||
| os.symlink(os.path.join(root_path, "plop.txt"), os.path.join(root_path, "plop_sym_link.txt")) | |||
| os.symlink(os.path.join(root_path, "dir1"), os.path.join(root_path, "dir2")) | |||
There was a problem hiding this comment.
Could this line be removed?
cchampet
reviewed
Nov 7, 2016
| - 2 hard links (. and ..) | ||
| - sizes | ||
| """ | ||
| print("testFolderLinkStat:") |
There was a problem hiding this comment.
Could these print be removed?
cchampet
reviewed
Nov 7, 2016
|
|
||
| def testLinkType(): | ||
| """ | ||
| Check stats of a synbolic link folder. |
There was a problem hiding this comment.
Could you update this doc? Something like:
"""
Check the type of the items found.
"""
cchampet
reviewed
Nov 7, 2016
|
|
||
| # create sym link | ||
| os.symlink(os.path.join(root_path, "plop.txt"), os.path.join(root_path, "plop_sym_link.txt")) | ||
| os.symlink(os.path.join(root_path, "dir1"), os.path.join(root_path, "dir2")) |
There was a problem hiding this comment.
What do you think to rename dir2 to dir1_sym_link?
There was a problem hiding this comment.
The aim is to test the browse method when folder sequence detected
There was a problem hiding this comment.
Oups yes you are right: so the name dir2 is important.
fabiencastan
reviewed
Nov 7, 2016
| @@ -154,7 +154,7 @@ std::vector<Item> browse( | |||
| // It's a sequence of directories, so it's not a sequence. | |||
| BOOST_FOREACH( Time t, s.getFramesIterable() ) | |||
| { | |||
| output.push_back( Item( eTypeFolder, directory / s.getFilenameAt(t) ) ); | |||
| output.push_back( Item( getTypeFromPath(directory / s.getFilenameAt(t)), directory / s.getFilenameAt(t) ) ); | |||
There was a problem hiding this comment.
You can create a variable for directory / s.getFilenameAt(t).
cchampet
reviewed
Nov 7, 2016
| @@ -154,14 +154,16 @@ std::vector<Item> browse( | |||
| // It's a sequence of directories, so it's not a sequence. | |||
| BOOST_FOREACH( Time t, s.getFramesIterable() ) | |||
| { | |||
| output.push_back( Item( getTypeFromPath(directory / s.getFilenameAt(t)), directory / s.getFilenameAt(t) ) ); | |||
| boost::filesystem::path folderPath = directory / s.getFilenameAt(t); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#61