Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow type: "null" #16

Closed
wants to merge 1 commit into from
Closed

Allow type: "null" #16

wants to merge 1 commit into from

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Jul 27, 2018

type: "null" is valid both in JSON schema v4 and in OpenAPI 2.0.

@mikunn
Copy link
Owner

mikunn commented Jul 28, 2018 •
edited
Loading

type: "null" is not valid as it's not explicitly mentioned in the schema. It's a bit misleading.

@ehmicky
Copy link
Contributor Author

ehmicky commented Jul 29, 2018 •
edited
Loading

Yes that's true. The current behavior of this library to convert nullable is actually what's expected according to OpenAPI 3.

@ehmicky ehmicky closed this Jul 29, 2018
@ehmicky ehmicky reopened this Jul 29, 2018
@ehmicky ehmicky closed this Jul 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehmicky @mikunn