Remove machine translation and add a link to an external repo #63
Conversation
rizar
changed the title
|
Because Blocks-examples and NMT demo have quite different purposes. Blocks-examples is supposed to contain minimalistic toy examples of using Blocks. We would like to keep it small, especially in terms of the maximum size of an example. We are committed to keep all examples fully functional for the cutting-edge Blocks, which means that for every Blocks PR necessary changes have to be applied here. NMT demo, on the other hand, is a fully-functional machine translation implementation. It's purpose is to reproduce results from a few machine translation papers. It has a lot of code dealing with real-world issues specific to machine translation and also attracts a broad audience that does not want to learn anything about Blocks or even Theano, but just wants to train a machine translation model. Trying to sum it up, I don't think that Blocks-examples should contain real-world examples with all their overwhelming complexity, because this is too much of a load for Blocks maintainers. |
|
@rizar to double check, according to b29e1fc, i'm moving it under https://github.com/orhanf/neural-MT , is that good or will be moved to another repo? |
|
This URL is just a placeholder to start the discussion. Maybe this should On 23 November 2015 at 11:32, Orhan Firat notifications@github.com wrote:
|
| @@ -52,3 +52,4 @@ Blocks: | |||
| * `Character-level RNN <https://github.com/johnarevalo/blocks-char-rnn>`_ | |||
| * `DRAW model <https://github.com/jbornschein/draw>`_ | |||
| * `Speech recognition <https://github.com/rizar/attention-lvcsr>`_ | |||
| * `Machine Translation <https://github.com/orhanf/neural-MT>`_ | |||
There was a problem hiding this comment.
maybe don't capitalize the T, to be consistent with "speech recognition" above.
Otherwise,, everything LGTM.
|
Looks like we will need the fix from mila-iqia/blocks@e185f3d for the buildbot. |
Let us start the procedure of moving the machine translation code out of Blocks-examples. @orhanf , would you like to create a new repository for it? Or maybe I should create a new repository under @mila-udem? What do you guys think, @bartvm and @dwf?