Add relay implementation to fully support conv2d_transpose in relay backend #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notoraptor
force-pushed
the
relay-conv2d-transpose
branch
from
6a12372
to
0042a08
Compare
|
All tests succeed! |
breuleux
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts code from #338 and adds supplementary code to fix
conv2d_transposein relay backend. It is currently implemented as a full relay graph and seems to correctly support all values for groups, dilations, and other parameters.This PR needs relay operation
dilateto be added in TVM backend. I made a PR for that: apache/tvm#5331This way to do was more easy than changing all conv2d_transpose implementations in TVM backend. If everything is confirmed and all tests pass, I may work on hardcoding the relay graph implementation directly into TVM backend.
@breuleux @abergeron @fosterrath-mila