Update libcramjam crate to 0.3.0 in cramjam-cli #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milesgranger
approved these changes
Apr 1, 2024
There was a problem hiding this comment.
Thanks, @musicinmybrain. Updating the capi and CLI are on my todo list for the added XZ stuff. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though this PR doesn’t contain the necessary work to actually expose the new xz support in the CLI, there don’t appear to be any relevant backwards-incompatibilities from
libcramjam0.2.x to 0.3.x, so it should be safe to build with the current release. The executable still builds, and I usedpytestto confirm the tests still pass, with this PR applied.Applying this as a downstream patch for
cramjam-cli0.1.1 in Fedora will allow me to avoid carrying arust-libcramjam0.2compat package in Fedora 40 and later. (I plan to use the compat package in the stable Fedora 38 and 39 releases to avoid breaking the C ABIs of the existing packagedlibcramjamshared libraries.)