Typed annotations

[milesgranger]

Will close #20

[DarkDrek]

I don't think we should mix documentation and annotations.
And naming wise it shouldn't be ModuleAttr and Atrr but Scope-Attribute and Item-Attribute (or something like that).
Because #![warn(...)] can also be the fist thing inside a function and then it applies to the whole function scope.

[milesgranger]

Ah right, of course. Thank you. 👍

[DarkDrek]

Can you implement the Verify trait for Annotation?

[milesgranger]

Not sure if it's possible? Doesn't appear Parse is implemented for Attribute https://docs.rs/syn/1.0.7/syn/struct.Attribute.html

So I get this:

  --> tests/utilities/mod.rs:19:6
   |
19 | impl Verify for Annotation {
   |      ^^^^^^ the trait `syn::parse::Parse` is not implemented for `syn::attr::Attribute`

[DarkDrek]

Can you apply this https://docs.rs/syn/1.0.5/syn/struct.Attribute.html#parsing-from-tokens-to-attribute ? But for this would have to provide a new trait or a supertrait of Verify so it may be too much work

[milesgranger]

Awesome, I can look at it tomorrow probably. Also, I would not be offended if you feel like hijacking this PR if you want. 👍

[DarkDrek]

Ok if I find time I can try 👍. I hope you also didn't fell offended by my remarks 👋

[milesgranger]

haha, never! More comments the better, my Rust skills are a work in progress anyway so I appreciate it!

[milesgranger]

If you're good with it, we can add a separate issue for implementing Verify/Parse for Annotation after this is in. Otherwise it probably won't be until after next week I can finish this. But again, you are welcome to take it over, my feelings won't be hurt. 😄

[milesgranger]

..in the larger picture, should this rather be called Attribute instead of Annotation?