Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Japanese translations. #169

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

logue
Copy link

@logue logue commented Mar 29, 2024

No description provided.

@milesj
Copy link
Owner

milesj commented Mar 29, 2024

@logue Thanks for the PR.

Just need to fix some failing tests. Looks like most of them are failing because of the non-standard number characters.

@logue
Copy link
Author

logue commented Mar 30, 2024

I see.
Maybe it's because I used full-width numbers.
I'll fix it.

Update Japanese translations.
@milesj
Copy link
Owner

milesj commented Apr 1, 2024

Just a few more left, hard to tell what the problem is. Maybe this regex needs to be updated? https://github.com/milesj/emojibase/blob/master/packages/regex/shortcode-native.js#L12

@logue
Copy link
Author

logue commented Apr 1, 2024

Just a few more left, hard to tell what the problem is. Maybe this regex needs to be updated? https://github.com/milesj/emojibase/blob/master/packages/regex/shortcode-native.js#L12

Strictly speaking, this definition is insufficient.
For Hiragana, this includes u31xx, which also includes Hangul radicals and Chinese bopomofo.

Also, for the kanji part, a common table is used for Japan, China, and Korea. This area is u2E00 to u9FFF, but also includes uF9xx and uFAxx. The error may be caused by the kanji in this part.

It's in Japanese, but for reference, the blue-purple parts of the table on the website below are the CJK kanji.
https://tools.m-bsys.com/ex/unicode_table.php

@milesj
Copy link
Owner

milesj commented Jun 3, 2024

@logue Sorry, forgot about this.

Each time you push changes, can you ping me so I'm aware and I can re-run CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants