Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs #1032

Merged
merged 2 commits into from
Jul 30, 2020
Merged

Add docs #1032

merged 2 commits into from
Jul 30, 2020
+55 −23

Conversation

kazchimo
Copy link
Contributor

just add docs walking around the codebase with minor refactorings.

@kazchimo kazchimo marked this pull request as draft June 27, 2020 06:59
@kazchimo kazchimo marked this pull request as ready for review June 27, 2020 07:05
joroKr21
joroKr21 requested changes Jun 28, 2020
View reviewed changes
Copy link
Collaborator

@joroKr21 joroKr21 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on docs! 👍
There are few things that I think we should make clearer.

@kazchimo kazchimo force-pushed the add_docs branch 3 times, most recently from 3ea488b to f86e278 Compare July 2, 2020 12:09
@joroKr21 joroKr21 added this to the shapeless-2.4.0 milestone Jul 30, 2020
@joroKr21 joroKr21 merged commit 3d6ae8f into milessabin:master Jul 30, 2020
@joroKr21 joroKr21 mentioned this pull request Apr 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joroKr21 joroKr21 joroKr21 approved these changes

Assignees

@kazchimo kazchimo

Labels
Documentation
Projects
None yet
Milestone
shapeless-2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kazchimo @joroKr21