-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce 2.12 / 2.13 Jar size by using instance constructors #1158
Conversation
5426a00
to
b9942d9
Compare
Generate less anonymous classes for implicit instances, esp. for tuple and function instances which are code generated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retrospectively ... LGTM!
@joroKr21 this probably breaks bincompat on 2.12 only Moving
|
@catostrophe that is surprising to me - I thought type aliases are erased and moving them around doesn't break binary compatibility. Also MiMa didn't complain. So maybe something more going on. Will have to investigate ... |
@joroKr21 It works on 2.13.5, but fails on 2.12.13 |
I opened lightbend-labs/mima#627 |
Oh no. The whole |
@joroKr21 could you add a comment to 2.3.6 release notes that it shouldn't be used? |
Generate less anonymous classes for implicit instances,
esp. for tuple and function instances which are code generated.
Note: this slightly increases the Jar size on 2.11 because it doesn't translate to
LambdaMetaFactory