Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed allocation in object Tag #705

Merged
merged 3 commits into from
Mar 15, 2020
Merged

Conversation

Arneball
Copy link

No description provided.

Change-Id: Icde7d4044c2c75e3df8ce164f5df2a4371fc02c2
@milessabin
Copy link
Owner

This is fine, but it's binary incompatible so it'll have to wait until the 2.4.0.

Can you point to an example project where the allocation you're removing here is an issue in practice?

@milessabin milessabin added this to the shapeless-2.4.0 milestone Apr 18, 2017
@milessabin milessabin self-assigned this Apr 18, 2017
@Atry
Copy link
Contributor

Atry commented Apr 21, 2017

IIRC, Hotspot JVM can easily eliminate these kind of allocation.

@Arneball
Copy link
Author

Arneball commented Apr 21, 2017 via email

@joroKr21 joroKr21 merged commit 1e282e0 into milessabin:master Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants