-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Lazy for tagged types #797
Conversation
Codecov Report
@@ Coverage Diff @@
## master #797 +/- ##
========================================
Coverage ? 87.9%
========================================
Files ? 65
Lines ? 1497
Branches ? 5
========================================
Hits ? 1316
Misses ? 181
Partials ? 0
Continue to review full report at Codecov.
|
This is great, thank you @joroKr21 ! |
Does this change actually break the test you've modified? |
Yes, the unmodified test fails because of ambiguous implicits, since the workaround for #309 is not necessary when deriving a typeclass instance for case class. However, it cannot be completely removed, because it is still necessary for the tests in |
Gotcha ... I'm going to defer this to 2.4.0 and hopefully get a fix for scala/bug#10506 into 2.13.0. |
8a4680b
to
c4ed791
Compare
9f17b7e
to
74f43f6
Compare
74f43f6
to
d7d25ae
Compare
d7d25ae
to
fc1befc
Compare
@milessabin should we merge this for 2.4.0? |
Yes, I think so. |
Fixes #584
Funny thing, this is also a partial fix for #309, but it looks like some types are automatically dealiased by Scala (e.g.
lgen.Repr
andRecord.{..fields}.T
) and in this case scala/bug#10506 kicks in.