Optimize SelectRange typeclass derivation #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joroKr21 I'd appreciate your eyeballs on this :-) |
joroKr21
reviewed
Mar 2, 2020
|
LGTM but I'm not sure about the naming. |
joroKr21
approved these changes
Mar 2, 2020
|
@Ssstlis one more thing before merge, would you mind squashing all commits into one? |
|
squashed and rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all!
Once i've find out the SelectRange is useful, but i don't understand why is this instances are so hard to derive (too much unnecessary recursive calling).
So i decide to optimize this derivation and it still works and looks good.