Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constrain tuple syntax with IsTuple #979

Merged
merged 3 commits into from
Mar 22, 2020
Merged

Constrain tuple syntax with IsTuple #979

merged 3 commits into from
Mar 22, 2020

Conversation

joroKr21
Copy link
Collaborator

@joroKr21 joroKr21 requested a review from milessabin March 16, 2020 17:14
@joroKr21 joroKr21 self-assigned this Mar 16, 2020
@joroKr21 joroKr21 added this to the shapeless-2.4.0 milestone Mar 16, 2020
@joroKr21
Constrain tuple syntax with IsTuple
5891711 
  * Resolves ambiguity with product syntax
  * Allows to correctly generalize (including unit)
milessabin
milessabin approved these changes Mar 21, 2020
View reviewed changes
Copy link
Owner

@milessabin milessabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joroKr21 joroKr21 merged commit 9b2776c into milessabin:master Mar 22, 2020
@joroKr21 joroKr21 deleted the tuple-syntax branch April 24, 2021 11:53
@joroKr21 joroKr21 mentioned this pull request Apr 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milessabin milessabin milessabin approved these changes

Assignees

@joroKr21 joroKr21

Labels
Design/refactoring
Projects
None yet
Milestone
shapeless-2.4.0
Development

Successfully merging this pull request may close these issues.

Conflicts between syntax.std.tuple and syntax.std.product
2 participants
@joroKr21 @milessabin