Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing asInstanceOf call #984

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Add missing asInstanceOf call #984

merged 1 commit into from
Jul 30, 2020

Conversation

joroKr21
Copy link
Collaborator

fixes #889

@joroKr21 joroKr21 added the Bug label Mar 20, 2020
@joroKr21 joroKr21 added this to the shapeless-2.4.0 milestone Mar 20, 2020
@joroKr21 joroKr21 requested a review from milessabin March 20, 2020 17:05
@joroKr21 joroKr21 self-assigned this Mar 20, 2020
@milessabin
Copy link
Owner

Why is the cast needed there?

@joroKr21
Copy link
Collaborator Author

Why is the cast needed there?

Because Scala won't infer Id. But it seems that it doesn't work for all versions 🤔

@joroKr21
Copy link
Collaborator Author

Looks like this will only work on Scala 2.13 so let's leave it for 2.5.0

@joroKr21 joroKr21 modified the milestones: shapeless-2.4.0, shapeless-2.5.0 Mar 24, 2020
@joroKr21
Copy link
Collaborator Author

@milessabin I think we should still merge that because it improves the situation on Scala 2.13

milessabin
milessabin approved these changes Jul 30, 2020
View reviewed changes
Copy link
Owner

@milessabin milessabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joroKr21 joroKr21 modified the milestones: shapeless-2.5.0, shapeless-2.4.0 Jul 30, 2020
@joroKr21 joroKr21 merged commit 0687c03 into milessabin:master Jul 30, 2020
@joroKr21 joroKr21 deleted the hkt-id-selector branch July 30, 2020 15:38
@joroKr21 joroKr21 mentioned this pull request Apr 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milessabin milessabin milessabin approved these changes

Assignees

@joroKr21 joroKr21

Labels
Bug
Projects
None yet
Milestone
shapeless-2.4.0
Development

Successfully merging this pull request may close these issues.

Implicit inference for ops.record.Selector doesn't work when Id is passed to a HKT
2 participants
@joroKr21 @milessabin