Add mkAttributedRef specialized for SingleType #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
References to singleton types should refer to the getter if possible. Fixes an issue where we would try to reference a non-existing field.
joroKr21
commented
Mar 27, 2020
| @@ -1017,7 +1021,7 @@ class GenericMacros(val c: whitebox.Context) extends CaseClassMacros { | |||
| } | |||
|
|
|||
| def mkProductGeneric(tpe: Type): Tree = { | |||
| val repr = mkHListTypTree(fieldsOf(tpe).map(_._2)) | |||
| val repr = mkHListTpe(fieldsOf(tpe).map(_._2)) | |||
There was a problem hiding this comment.
Now mkHListTypTree is not used in shapeless anymore.
But it might be wise to keep it because people might be using it in their own macros.
There was a problem hiding this comment.
I'm fine removing it for 2.4.0.
There was a problem hiding this comment.
Ok it turns out there is a lot of dead code already 😄
joroKr21
commented
Mar 27, 2020
| case _ => | ||
| cq"_: $tpe0 => $index" | ||
| } | ||
|
|
||
| val coproduct = objectRef[Coproduct.type] | ||
| val ctors = ctorsOf(tpe) | ||
| val repr = mkCoproductTypTree(ctors) | ||
| val repr = mkCoproductTpe(ctors) |
There was a problem hiding this comment.
Now mkCoproductTypTree is not used in shapeless anymore.
But it might be wise to keep it because people might be using it in their own macros.
|
Latest nightly was green ... we're good to go 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References to singleton types should refer to the getter if possible.
Fixes an issue where we would try to reference a non-existing field.