Added option to skip the prefix of temp files with file:/// #889
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made two changes:
1/ Added option
option[:slip_file_prefix]
that preventspdf_from_string
from calling .pdf_from_html_file
and callspdf_from_url
directly.2/ This option also influences the temp file that is created for header/footer content
3/ Passed the
options[:temp_path]
to the Tempfile that is being created for the header/footer content.