Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to skip the prefix of temp files with file:/// #889

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bo-oz
Copy link

@bo-oz bo-oz commented Feb 24, 2020

Made two changes:

1/ Added option option[:slip_file_prefix] that prevents pdf_from_string from calling .pdf_from_html_file and calls pdf_from_url directly.
2/ This option also influences the temp file that is created for header/footer content
3/ Passed the options[:temp_path] to the Tempfile that is being created for the header/footer content.

@bo-oz bo-oz mentioned this pull request Feb 24, 2020
@unixmonkey
Copy link
Collaborator

@bo-oz Why is this desirable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants