fix: bail if the commit message use a fixup! prefix #32
+17
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Bail if commit message already contains tickets | ||
| if any(re.search(regex, content) for content in contents): | ||
| # Bail if commit message starts with “fixup!” or commit message already contains tickets | ||
| if commit_msg.startswith('fixup!') or any(re.search(regex, content) for content in contents): |
There was a problem hiding this comment.
Can this be anything else than "fixup!? Assuming it always will be, if not, could make it configurable in pre commit config. If its the former then I think its fine.
There was a problem hiding this comment.
There is indeed the amend! prefix too in the documentation, I don't think it's configurable by any means
Neither "fixup!" nor "amend!" commits change authorship of when applied by git rebase --autosquash. See git-rebase[1] for details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for your work !
When I use the
--fixupoption the issue number keep repeating itself each time. As a reminder "fixup" commit reference the targeted commit message (which may already contain the issue number), regardless of if the issue number is present or not,--autosquashfeature combine commits with the exact same message.This PR bails on every message starting with
fixup!tag (documentation)