Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #66, #118, #137, #140, #192, #206
^ This seems to be the most pressing issue to resolve. I'm hoping to fix python3 compatibility once and for all in this branch. Looking for feedback from anyone who knows more about this stuff.
Notes on the changes in here:
draw
function if you do not decode the string into utf-8 and there are non-ascii characters in the string, because concatenating a unicode object and a string causes Python to try to implicitly convert the ASCII to unicode, but can't convert the non-ascii character. Here is some that demos this:str.decode
function.subprocess
functions returnbytes
instead ofunicode
. Thus we must always decode the bytes into unicode. This works just fine though since in Python 2,subprocess
returns strings which must also be decoded into unicode.Tests:
cd
into directory with non-ascii character in its name (py2)cd
into directory with non-ascii character in its name (py3)