Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use store_true for --use_preset #79

Merged
merged 1 commit into from
Jul 16, 2024
Merged

use store_true for --use_preset #79

merged 1 commit into from
Jul 16, 2024

Conversation

milkschen
Copy link
Owner

There was no way to set --use_preset to False with the previous logic. This PR changes the argparse argument to fix it.

Impact

This change affects users currently using --use_preset=True. But it is fairly straightforward to troubleshoot. The workflow README is also updated to reflect the change.

@milkschen
Copy link
Owner Author

Thanks to @nhansen for reporting the issue!

@milkschen milkschen merged commit 4774343 into main Jul 16, 2024
1 check passed
@milkschen milkschen deleted the workflow branch July 16, 2024 06:11
@pickettbd
Copy link

I think type=bool needs to be removed in conjunction with the addition of action="store_true":

TypeError: _StoreTrueAction.__init__() got an unexpected keyword argument 'type'

@milkschen
Copy link
Owner Author

I think it has been removed?

parser.add_argument(
"--use_preset",
action="store_true",
help="Use default workflow parameters",
)

@pickettbd
Copy link

Quite right! I must have looked in the wrong place or grabbed the wrong version or something. Sorry about that. And thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants