Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prepare app for upgrade #106

Merged
merged 11 commits into from
Sep 19, 2024
Merged

Conversation

RiccardoM
Copy link
Contributor

@RiccardoM RiccardoM commented Sep 10, 2024

Description

This PR adds an upgrade handler to make sure that the testnet can be upgraded from the current v1.0.0 version to the new v1.1.0 version properly.

It also includes some code fixes like missing autocli configurations and services registering.

To make sure that upgrade goes smoothly, some migration implementations have been added to properly set the params of new modules to default values. Also, the params for the x/assets module has been removed as it was empty and not used inside the codebase.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

x/services/legacy/v2/store.go Outdated Show resolved Hide resolved
app/upgrades/v110/upgrade.go Show resolved Hide resolved
x/rewards/autocli.go Show resolved Hide resolved
Copy link
Contributor

@hallazzang hallazzang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hallazzang hallazzang merged commit 583293d into main Sep 19, 2024
16 checks passed
@hallazzang hallazzang deleted the riccardom/add-v110-upgrade-handler branch September 19, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants