Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/initia-labs/initia to v0.5.6 #117

Closed
wants to merge 5 commits into from

Conversation

RiccardoM
Copy link
Contributor

Description

This PR updates our codebase to use version 0.5.6 of github.com/initia-labs/initia.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@RiccardoM RiccardoM requested a review from hallazzang October 7, 2024 17:15
// MakeTestEncodingConfig creates an EncodingConfig for testing
func MakeTestEncodingConfig(t *testing.T) params.EncodingConfig {
t.Helper()
return makeEncodingConfig(simtestutil.NewAppOptionsWithFlagHome(t.TempDir()))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed to avoid the following error when creating a new CosmWasm keeper:

Could not lock exclusive.lock. Is a different VM running in the same directory already?

By using t.TempDir as the home directory when creating the app, the CosmWasm keeper will create the lock file inside a subfolder of that directory. This will avoid any issue due to conflicts since each test creates a custom temporary directory when it's run.

@hallazzang
Copy link
Contributor

I think I've done a duplicated work in #119 😓

@RiccardoM RiccardoM force-pushed the riccardom/update-initia branch from f64db75 to 38177c5 Compare October 8, 2024 15:04
@RiccardoM
Copy link
Contributor Author

@hallazzang I think we can use this one. What do you think? If you see that the changes that I've made are all the ones necessary could you please accept this so that we can try running a new testnet? Thanks! 🙏

@hallazzang
Copy link
Contributor

hallazzang commented Oct 8, 2024

@RiccardoM

@hallazzang I think we can use this one. What do you think? If you see that the changes that I've made are all the ones necessary could you please accept this so that we can try running a new testnet? Thanks! 🙏

Well we need to check if these changes are just enough. Can you tell me which method did you use to do the upgrade? I see some same changes with miniwasm v0.5.x made here but not all. Did you cherry pick some commits? Cause I cherry-picked(sometimes without git cherry-pick) all changes.

@RiccardoM
Copy link
Contributor Author

@hallazzang

Can you tell me which method did you use to do the upgrade?

I've just upgraded the dependency and fixed the issues by either copy/pasting the changes or manually fixing imports and such. If you are more confident with your changes, we can use your PR. Just make sure that linting, building and tests pass fine.

@RiccardoM
Copy link
Contributor Author

Closing in favor of #119

@RiccardoM RiccardoM closed this Oct 8, 2024
@RiccardoM RiccardoM deleted the riccardom/update-initia branch November 22, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants