Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve x/stakeibc admin check #123

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

RiccardoM
Copy link
Contributor

Description

This PR improves the x/stakeibc admin account check by removing the existing ValidateAdminAccount method that checks the validity of an account using a hardcoded list of addresses. Instead, a dynamic check is performed to make sure that the sending account is either:

  1. the authority address of the x/stakeibc module, or
  2. the admin address of the x/opchild module

This makes sure that if we start a chain with any arbitrary validator address, they will always be able to perform these messages together with the governance module.

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@RiccardoM
Copy link
Contributor Author

Merging this as I've tested it on our testnet and it works properly 👍

@RiccardoM RiccardoM merged commit d8a24df into main Oct 11, 2024
16 checks passed
@RiccardoM RiccardoM deleted the riccardom/improve-stakeibc-admin-check branch October 11, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant