Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support response headers policy #265

Merged
merged 1 commit into from
Jan 23, 2022
Merged

feat: support response headers policy #265

merged 1 commit into from
Jan 23, 2022

Conversation

aquanow-jeffen
Copy link
Contributor

#262 Tested based on project examples on my aws account and works as expected!

Thanks for reviewing!

data "aws_cloudfront_response_headers_policy" "managed_security_headers" {
  name = "Managed-SecurityHeadersPolicy"
}

module "tf_next" {
  source = "milliHQ/next-js/aws"

  deployment_name                    = "tf-next-example-complete"
  cloudfront_response_headers_policy = data.aws_cloudfront_response_headers_policy.managed_security_headers.id

@ofhouse ofhouse linked an issue Jan 23, 2022 that may be closed by this pull request
[Question] add security headers on cloudfront response? #262
Closed
@ofhouse ofhouse added this to the Next Iteration milestone Jan 23, 2022
ofhouse
ofhouse approved these changes Jan 23, 2022
View reviewed changes
Copy link
Member

@ofhouse ofhouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for contributing!

@ofhouse ofhouse merged commit 09376fb into milliHQ:main Jan 23, 2022
ofhouse added a commit that referenced this pull request Jan 23, 2022
@ofhouse
Bump required aws provider from 3.43.0 to 3.64.0
6341aa2 
For using response_headers_policy_id which was introduced in #265
@ofhouse ofhouse mentioned this pull request Jan 23, 2022
Merged
ofhouse added a commit that referenced this pull request Jan 23, 2022
@ofhouse
Bump required aws provider from 3.43.0 to 3.64.0 (#268)
9868688 
For using response_headers_policy_id which was introduced in #265
@ofhouse
Copy link
Member

ofhouse commented Jan 23, 2022

This has now been released in v0.11.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofhouse ofhouse ofhouse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.11.2
Development

Successfully merging this pull request may close these issues.

[Question] add security headers on cloudfront response?
2 participants
@aquanow-jeffen @ofhouse