Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request cookie header should be semi-colon delimitated #39

Merged
merged 3 commits into from
Jan 18, 2021
Merged

Request cookie header should be semi-colon delimitated #39

merged 3 commits into from
Jan 18, 2021

Conversation

TheCallSign
Copy link
Contributor

Thanks for fixing #29!

Just one little bug left, cookies in the request header should be separated by semi-colons instead of commas.

ofhouse
ofhouse requested changes Jan 18, 2021
View reviewed changes
Copy link
Member

@ofhouse ofhouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, thanks for the review!
Only looked at the multi value header spec and thought that it is also valid for cookies 🙈

packages/node-bridge/test/bridge.test.js Show resolved Hide resolved
@ofhouse ofhouse merged commit fe7b54b into milliHQ:main Jan 18, 2021
@ofhouse
Copy link
Member

ofhouse commented Jan 18, 2021

This is now published in tf-next@0.4.1 (No need to update the Terraform module version).
Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofhouse ofhouse ofhouse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheCallSign @ofhouse