Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making ContinuousView struct field public #58

Open
quietlychris opened this issue Mar 16, 2020 · 0 comments
Open

Making ContinuousView struct field public #58

quietlychris opened this issue Mar 16, 2020 · 0 comments

Comments

@quietlychris
Copy link

quietlychris commented Mar 16, 2020

Hello,

In one of my projects using plotlib, (can be seen here), I'm overlaying several scatter plots in different colors into the same plot. In order of accomplish that, I'm using a pattern like the one below, which allows for an arbitrary number of individual scatter plots to be added to a single view. However, due to the borrow checker, and being unable to modify the ContinuousView struct field representations directly since it's not public, I've had to clone the library locally, modify it, and point my Cargo.toml file there instead.

Would it be possible to open up those fields publicly? I realize it's typical to leave them private by default, but I'm not sure if there's a soundness or security implication that would get in the way. Alternatively, is there a more idiomatic way of doing this?

let mut scatter_plots: Vec<Plot> = Vec::new();
for i in 0..clusters.len() {
    let mut rng = rand::thread_rng();
    let color = format!("#{}", rng.gen_range(0, 999999).to_string()); // This is just a convenient way of coming up with different colors
    let s: Plot = Plot::new(
        vec![clusters[i].clone()] // clusters is of type Vec<Vec<(f64,f64)>>
    )
    .point_style(PointStyle::new().colour(color));
    scatter_plots.push(c);
}

let mut v = ContinuousView::new()
    .x_range(-5., 5.)
    .y_range(-5., 5.)
    .x_label("x-axis")
    .y_label("y-axis");

for plot in scatter_plots {
    v.representations.push(Box::new(plot.clone())); // Can't do this because the `representations` field is currently private.
    // It compiles and works when I open that field publicly, though.

    // v.add(plot.clone()); // Can't do this because Copy can't be implement on ContinuousView because of a String dependency, so the borrow checker doesn't like it
    // I haven't found a way around this, since it seems to be based on language-level guarantees 
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants