Method on table fails to modify table state

[jeff-emanuel]

The following code does not change buffer as it does in Lua 5.3.4:

obj = { buffer = {} }
function obj.append(self,value) self.buffer[#self.buffer+1] = value end
obj:append(7)
print(#obj.buffer)
for i,v in ipairs(obj.buffer) do print(i,v) end

It also does not work when passing an explicit self parameter:

obj = { buffer = {} }
function obj.append(self,value) self.buffer[#self.buffer+1] = value end
obj.append(obj,7)
print(#obj.buffer)
for i,v in ipairs(obj.buffer) do print(i,v) end

The attached code prints 0 twice.

luamethod.zip

[milochristiansen]

Initial testing indicates a compiler error, as code compiled with luac works properly. I still need to identify where it is going wrong, but a fix should be available within the day.

[jeff-emanuel]

Thanks!

…

On Tue, Oct 23, 2018 at 12:10 PM Milo Christiansen ***@***.***> wrote: Initial testing indicates a compiler error, as code compiled with luac works properly. I still need to identify where it is going wrong, but a fix should be available within the day. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#16 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AhhKJ0DOCcycSN4hWLdfzT-wxTO5ctYrks5un1t_gaJpZM4X2Hjh> .

[milochristiansen]

Ok, the problem was pretty obvious once I thought to examine the object with pairs instead of ipairs. Turns out the compiler was using the same register for both key and value.

The issue was caused by the code that compiled identifiers not properly indicating how many registers it used in certain cases. I'll push the fix in the next minute or so. Hopefully it fixes all such cases, but if not let me know.

[jeff-emanuel]

Thanks again for the prompt response. It looks good.