Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick partition key fix and example #541

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

congqixia
Copy link
Contributor

/kind improvement

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Aug 3, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved review approved size/L Denotes a PR that changes 100-499 lines. labels Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #541 (016e629) into master (8b6a432) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #541      +/-   ##
==========================================
+ Coverage   82.55%   82.59%   +0.04%     
==========================================
  Files          39       39              
  Lines        3542     3540       -2     
==========================================
  Hits         2924     2924              
+ Misses        505      504       -1     
+ Partials      113      112       -1     
Files Changed Coverage Δ
client/insert.go 79.16% <ø> (+0.54%) ⬆️

@mergify mergify bot added the ci-passed auto merge needed label label Aug 3, 2023
@yah01
Copy link
Member

yah01 commented Aug 4, 2023

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Aug 4, 2023
@sre-ci-robot sre-ci-robot merged commit 1536418 into milvus-io:master Aug 4, 2023
6 checks passed
@congqixia congqixia deleted the cp_partitionkey_fix branch August 28, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/improvement Changes related to something improve, likes ut and code refactor lgtm look good to me size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants