Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: enable setting properties during create database #782

Merged
merged 1 commit into from
Jul 16, 2024
Merged

enhance: enable setting properties during create database #782

merged 1 commit into from
Jul 16, 2024

Conversation

weiliu1031
Copy link
Contributor

@sre-ci-robot sre-ci-robot requested review from sunby and yah01 July 5, 2024 06:25
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jul 5, 2024
@weiliu1031
Copy link
Contributor Author

rerun ut

@weiliu1031 weiliu1031 force-pushed the enable_pass_parops_during_create_db branch from 5bda89c to f7f6dfa Compare July 5, 2024 07:33
@mergify mergify bot added the ci-passed auto merge needed label label Jul 5, 2024
@weiliu1031 weiliu1031 changed the title enhance: enable setting properties during create database enhance: Enable setting the replica number and resource group during collection creation Jul 9, 2024
congqixia
congqixia reviewed Jul 9, 2024
View reviewed changes
client/options.go Outdated Show resolved Hide resolved
@weiliu1031 weiliu1031 changed the title enhance: Enable setting the replica number and resource group during collection creation enhance: enable setting properties during create database Jul 9, 2024
@weiliu1031 weiliu1031 force-pushed the enable_pass_parops_during_create_db branch from f7f6dfa to 36d6c8a Compare July 10, 2024 11:39
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Jul 10, 2024
@mergify mergify bot removed the ci-passed auto merge needed label label Jul 10, 2024
@weiliu1031
Copy link
Contributor Author

rerun ut

@weiliu1031 weiliu1031 force-pushed the enable_pass_parops_during_create_db branch 4 times, most recently from 558a1dc to 092619a Compare July 16, 2024 07:05
@weiliu1031
enhance: enable setting properties during create database
9d07bc8 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@weiliu1031 weiliu1031 force-pushed the enable_pass_parops_during_create_db branch from 092619a to 9d07bc8 Compare July 16, 2024 09:55
@mergify mergify bot added the ci-passed auto merge needed label label Jul 16, 2024
congqixia
congqixia approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Jul 16, 2024
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the approved review approved label Jul 16, 2024
@sre-ci-robot sre-ci-robot merged commit 71ec76e into milvus-io:master Jul 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@sunby sunby Awaiting requested review from sunby

@yah01 yah01 Awaiting requested review from yah01

Assignees

@congqixia congqixia

Labels
approved review approved ci-passed auto merge needed label lgtm look good to me size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weiliu1031 @sre-ci-robot @congqixia