Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Allow explicit dynamic JSON column as insert data #807

Merged

Conversation

congqixia
Copy link
Contributor

Related to #806

Previously all columns not appeared in schema definition are treated as dynamic columns. This PR allows specifying one JSON column to be the THE dynamic column data.

Related to milvus-io#806

Previously all columns not appeared in schema definition are treated as
dynamic columns. This PR allows specifying one JSON column to be the
THE dynamic column data.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved review approved size/S Denotes a PR that changes 10-29 lines. labels Aug 19, 2024
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Aug 19, 2024
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia
Copy link
Contributor Author

/kind enhancement

@sre-ci-robot sre-ci-robot added the kind/enhancement New feature or request label Aug 19, 2024
@congqixia congqixia changed the title enhance: Allow explict dynamic JSON column as insert data enhance: Allow explicit dynamic JSON column as insert data Aug 19, 2024
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia merged commit 542b5a0 into milvus-io:master Aug 19, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved kind/enhancement New feature or request size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants