Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add page retain order #813

Merged
merged 1 commit into from
Sep 14, 2024
Merged

feat: add page retain order #813

merged 1 commit into from
Sep 14, 2024

Conversation

PwzXxm
Copy link
Contributor

@PwzXxm PwzXxm commented Aug 30, 2024

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Aug 30, 2024
@PwzXxm
Copy link
Contributor Author

PwzXxm commented Sep 2, 2024

/hold

@PwzXxm
Copy link
Contributor Author

PwzXxm commented Sep 3, 2024

/unhold

@PwzXxm PwzXxm force-pushed the add_page_retain_order branch 2 times, most recently from d0881b1 to 0a9dbc3 Compare September 6, 2024 02:30
@PwzXxm
Copy link
Contributor Author

PwzXxm commented Sep 6, 2024

Waiting for CI Fix.

@PwzXxm
feat: add page retain order for range search
a1f6fff 
Signed-off-by: Patrick Weizhi Xu <weizhi.xu@zilliz.com>
@mergify mergify bot added the ci-passed auto merge needed label label Sep 11, 2024
congqixia
congqixia approved these changes Sep 14, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Sep 14, 2024
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, PwzXxm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the approved review approved label Sep 14, 2024
@sre-ci-robot sre-ci-robot merged commit 110516d into milvus-io:master Sep 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@yah01 yah01 Awaiting requested review from yah01

Assignees

@congqixia congqixia

Labels
approved review approved ci-passed auto merge needed label lgtm look good to me size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PwzXxm @sre-ci-robot @congqixia