Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update error message and other behavior change #841

Merged
merged 4 commits into from
Nov 7, 2024

Conversation

congqixia
Copy link
Contributor

This PR fix the failing e2e cases for master branch

  • Error message changes for expression validation
  • Skip timeout & unexpected message change
  • Use current consistency level param to avoid iterator issues

This PR fix the failing e2e cases for master branch

- Error message changes for expression validation
- Skip timeout & unexpected message change
- Use current consistency level param to avoid iterator issues

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved review approved size/XXL Denotes a PR that changes 1000+ lines. labels Nov 7, 2024
@congqixia
Copy link
Contributor Author

/kind bug

@sre-ci-robot sre-ci-robot added the kind/bug Something isn't working label Nov 7, 2024
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@mergify mergify bot added the ci-passed auto merge needed label label Nov 7, 2024
Copy link
Contributor

@ThreadDao ThreadDao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Nov 7, 2024
@sre-ci-robot sre-ci-robot merged commit ba486e3 into milvus-io:master Nov 7, 2024
7 checks passed
@congqixia congqixia deleted the fix/error_behavior branch November 7, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/bug Something isn't working lgtm look good to me size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants