Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable benchmark #151

Merged
merged 2 commits into from
Sep 30, 2024
Merged

fix: enable benchmark #151

merged 2 commits into from
Sep 30, 2024

Conversation

tedxu
Copy link
Collaborator

@tedxu tedxu commented Sep 29, 2024

No description provided.

@tedxu
fix: enable benchmark
e8ed17b 
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
@tedxu
Copy link
Collaborator Author

tedxu commented Sep 29, 2024

Benchmark result:

------------------------------------------------------------------------
Benchmark                              Time             CPU   Iterations
------------------------------------------------------------------------
S3Fixture/Write32MB/real_time   43236907 ns     38985846 ns           13
S3Fixture/Read32MB/real_time     9751422 ns      8241057 ns           70

Write is much slower than read, not sure if it is expected.

shaoting-huang
shaoting-huang reviewed Sep 29, 2024
View reviewed changes
cpp/benchmark/benchmark_packed.cpp
if (!r.ok()) {
st.SkipWithError(r.status().ToString());
auto r = arrow::RecordBatch::MakeEmpty(schema);
SKIP_IF_NOT_OK(r.status(), st)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it affect the benchmark result if we skip?

Copy link
Collaborator Author

@tedxu tedxu Sep 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skip means canceling the benchmark if there is error.

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shaoting-huang, tedxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [shaoting-huang,tedxu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tedxu
fix format
b1f61b3 
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
@shaoting-huang
Copy link
Collaborator

/lgtm

@sre-ci-robot sre-ci-robot merged commit 8b6ca71 into milvus-io:main Sep 30, 2024
2 checks passed
@tedxu tedxu deleted the fix/enable_benchmark branch September 30, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaoting-huang shaoting-huang shaoting-huang approved these changes

@sunby sunby Awaiting requested review from sunby

Assignees

@shaoting-huang shaoting-huang

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tedxu @sre-ci-robot @shaoting-huang