Fix flush failure caused by empty stale segments (#18097)

/bug issue: #18096 Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
milvus-io · Jul 6, 2022 · d4a1e94 · d4a1e94
1 parent 79523ff
commit d4a1e94
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/internal/datacoord/server.go b/internal/datacoord/server.go
@@ -641,7 +641,8 @@ func (s *Server) getStaleSegmentsInfo(ch string) []*SegmentInfo {
 		return isSegmentHealthy(info) &&
 			info.GetInsertChannel() == ch &&
 			!info.lastFlushTime.IsZero() &&
-			time.Since(info.lastFlushTime).Minutes() >= segmentTimedFlushDuration
+			time.Since(info.lastFlushTime).Minutes() >= segmentTimedFlushDuration &&
+			info.GetNumOfRows() != 0
 	})
 }
 

diff --git a/internal/datanode/data_node.go b/internal/datanode/data_node.go
@@ -621,8 +621,7 @@ func (node *DataNode) FlushSegments(ctx context.Context, req *datapb.FlushSegmen
 		log.Info("flow graph flushSegment tasks triggered",
 			zap.Bool("flushed", flushed),
 			zap.Int64("collection ID", req.GetCollectionID()),
-			zap.Int64s("segments", segmentIDs),
-			zap.Int64s("mark segments", req.GetMarkSegmentIDs()))
+			zap.Int64s("segments", segmentIDs))
 		return flushedSeg, noErr
 	}