Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Datacoord to support prioritization of compaction tasks #36550

Closed
1 task done
tedxu opened this issue Sep 26, 2024 · 1 comment
Closed
1 task done

[Enhancement]: Datacoord to support prioritization of compaction tasks #36550

tedxu opened this issue Sep 26, 2024 · 1 comment
Labels
kind/enhancement Issues or changes related to enhancement stale indicates no udpates for 30 days

Comments

@tedxu
Copy link
Contributor

tedxu commented Sep 26, 2024

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

Datacoord is triggering and submitting compaction tasks randomly, which is resulting in the blocking of certain critical tasks, especially those L0 compaction tasks.

Usually, a prioritization by L0>Mix>Major is preferred.

Why is this needed?

No response

Anything else?

No response
@tedxu tedxu added the kind/enhancement Issues or changes related to enhancement label Sep 26, 2024
@tedxu tedxu mentioned this issue Sep 26, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Oct 9, 2024
@tedxu
enhance: Datacoord to support prioritization of compaction tasks (#36547
5fc7317 
)

See #36550

This PR made 2 changes:

1. Introducing a prioritization mechanism, if
`dataCoord.compaction.taskPrioritizer` is set to `level`, compaction
tasks are always executed as the priority of L0>Mix>Clustering
2. `dataCoord.compaction.maxParallelTaskNum` now controls the
parallelism of executing tasks, not the task number of queue +
executing.

---------

Signed-off-by: Ted Xu <ted.xu@zilliz.com>
tedxu added a commit to tedxu/milvus that referenced this issue Oct 18, 2024
@tedxu
enhance: Datacoord to support prioritization of compaction tasks (mil…
6e42513 
…vus-io#36547)

See milvus-io#36550

This PR made 2 changes:

1. Introducing a prioritization mechanism, if
`dataCoord.compaction.taskPrioritizer` is set to `level`, compaction
tasks are always executed as the priority of L0>Mix>Clustering
2. `dataCoord.compaction.maxParallelTaskNum` now controls the
parallelism of executing tasks, not the task number of queue +
executing.

---------

Signed-off-by: Ted Xu <ted.xu@zilliz.com>
@tedxu tedxu mentioned this issue Oct 18, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Oct 18, 2024
@tedxu
enhance: Datacoord to support prioritization of compaction tasks (#36979
22838a8 
)

See #36550

pr: #36547 
pr: #36956

---------

Signed-off-by: Ted Xu <ted.xu@zilliz.com>
@stale Stale
Copy link

stale bot commented Oct 29, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Oct 29, 2024
@stale stale bot closed this as completed Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Issues or changes related to enhancement stale indicates no udpates for 30 days
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tedxu