Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop empty sealed segment (#17708) #17782

Closed
wants to merge 1 commit into from
Closed

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Jun 24, 2022

issue: #17508

Signed-off-by: sunby bingyi.sun@zilliz.com

Co-authored-by: sunby bingyi.sun@zilliz.com

Signed-off-by: sunby <bingyi.sun@zilliz.com>

Co-authored-by: sunby <bingyi.sun@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sunby
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jun 24, 2022
@mergify
Copy link
Contributor

mergify bot commented Jun 24, 2022

@sunby Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@mergify
Copy link
Contributor

mergify bot commented Jun 24, 2022

@sunby E2e jenkins job failed, comment /run-checks can trigger the job again.

@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #17782 (017846e) into 2.1.0 (6c47ea2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.1.0   #17782      +/-   ##
==========================================
+ Coverage   81.09%   81.10%   +0.01%     
==========================================
  Files         469      469              
  Lines       74586    74604      +18     
==========================================
+ Hits        60483    60507      +24     
+ Misses      11424    11416       -8     
- Partials     2679     2681       +2     
Impacted Files Coverage Δ
internal/datacoord/segment_manager.go 85.88% <100.00%> (+1.75%) ⬆️
internal/datacoord/services.go 86.45% <100.00%> (ø)
internal/mq/mqimpl/rocksmq/client/client_impl.go 77.96% <0.00%> (-2.55%) ⬇️
internal/indexnode/indexnode_mock.go 83.65% <0.00%> (-1.15%) ⬇️
internal/indexcoord/index_coord.go 77.82% <0.00%> (-0.64%) ⬇️
internal/querycoord/index_checker.go 74.25% <0.00%> (-0.60%) ⬇️
internal/querycoord/meta.go 79.95% <0.00%> (-0.43%) ⬇️
internal/datacoord/meta.go 87.09% <0.00%> (+0.12%) ⬆️
internal/datacoord/server.go 76.19% <0.00%> (+0.65%) ⬆️
internal/indexcoord/meta_table.go 85.18% <0.00%> (+0.69%) ⬆️
... and 5 more

@congqixia
Copy link
Contributor

/kind bug

@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label Jun 28, 2022
@mergify
Copy link
Contributor

mergify bot commented Jun 28, 2022

@sunby E2e jenkins job failed, comment /run-checks can trigger the job again.

@sunby sunby closed this Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/bug Issues or changes related a bug size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants