fix: [GoSDK] Loose rowbased insert data check #41498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to milvus-io#41460 This PR looses insert data check based on schema. These check shall actually happen at milvus server side. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sre-ci-robot
added
approved
area/test
size/L
mergify
bot
added
dco-passed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #41498 +/- ##
=======================================
Coverage 80.45% 80.45%
=======================================
Files 1493 1493
Lines 212393 212414 +21
=======================================
+ Hits 170873 170908 +35
+ Misses 35316 35296 -20
- Partials 6204 6210 +6
🚀 New features to boost your workflow:
|
|
@congqixia E2e jenkins job failed, comment |
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
Apr 30, 2025
Related to milvus-io#41460 This PR looses insert data check based on schema. These check shall actually happen at milvus server side. --------- Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
Apr 30, 2025
pr: milvus-io#41498 milvus-io#41576 milvus-io#41606 milvus-io#39973 Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot
pushed a commit
that referenced
this pull request
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #41460
This PR looses insert data check based on schema. These check shall actually happen at milvus server side.