Change DataFrame validation location selection to integer-location #265
Conversation
|
Welcome @NotRyan! It looks like this is your first PR to milvus-io/pymilvus-orm 🎉 |
|
@NotRyan Thanks for your first contribution 🎉 It seems the test action is unhappy about what you've changed. Could you help to fix the tests as well? |
Signed-off-by: NotRyan <ryan.chan@zilliz.com>
|
Hi @XuanYang-cn, I've fixed the issue that @xiaocai2333 pointed out and the tests seem to pass now. Here's the test and coverage report from my local machine. |
|
/approve |
|
/lgtm |
|
@xiaocai2333: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, NotRyan, xiaocai2333, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Resolves milvus-io/milvus#6677
Previously, Pandas dataframe validation iterated over the length of data present in a column, while making references to individual items by using the default location selection-by-index. This meant that validation would be successful when the dataframe index started from 0, but would cause errors when using sliced dataframes which started at a non-zero index, such as in milvus-io/milvus#6677
Switching to location selection-by-integer resolves this issue.
Signed-off-by: NotRyan ryan.chan@zilliz.com