Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add grpc compression #2007

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add grpc compression #2007

wants to merge 1 commit into from

Conversation

PowderLi
Copy link
Contributor

issue: #1911

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: PowderLi
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the dco-passed label Mar 28, 2024
@PowderLi
add grpc compression
de0b21e 
Signed-off-by: PowderLi <min.li@zilliz.com>
@mergify mergify bot added the ci-passed label Mar 28, 2024
XuanYang-cn
XuanYang-cn requested changes Apr 1, 2024
View reviewed changes
pymilvus/client/grpc_handler.py
@@ -84,6 +91,7 @@ def __init__(
self._log_level = None
self._request_id = None
self._user = kwargs.get("user", None)
self._compression_type = kwargs.get("compression_type", "none")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if compression_type is valid and raise meaningful exception, or the following dict[xxx] might raise KeyError exception

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuanYang-cn XuanYang-cn XuanYang-cn requested changes

@czs007 czs007 Awaiting requested review from czs007

@longjiquan longjiquan Awaiting requested review from longjiquan

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
ci-passed dco-passed size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PowderLi @sre-ci-robot @XuanYang-cn