Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more specific error when other wallet is outdated #162

Merged
merged 2 commits into from
Jun 26, 2019
Merged

Provide more specific error when other wallet is outdated #162

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc97619
add appropriate error message when other wallet is out of date
yeastplume Jun 26, 2019
6bc3e9f
rustfmt
yeastplume Jun 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion impls/src/adapters/http.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,15 @@ impl HTTPWalletCommAdapter {
});

let res: String = post(url, None, &req).map_err(|e| {
let report = format!("Performing version check (is recipient listening?): {}", e);
let mut report = format!("Performing version check (is recipient listening?): {}", e);
let err_string = format!("{}", e);
if err_string.contains("404") {
// Report that the other version of the wallet is out of date
report = format!(
"Other wallet is incompatible and requires an upgrade. \
Please urge the other wallet owner to upgrade and try the transaction again."
);
}
error!("{}", report);
ErrorKind::ClientCallback(report)
})?;
Expand Down