[WIP] Server authentication in transactions #186
Conversation
This reverts commit f52a8d2.
…ntors, visiting havok on automated tests, at least one of which is now out of date and failing
1. args, a stringly typed argument to put_tx 2. NullAdapter, which is no longer used
|
Blocked by #180 |
| Ok(s) => s, | ||
| Err(e) => return Err(ParseError::ArgumentError(format!("{}", e))), | ||
| }; | ||
| if cfg!(not(test)) { |
There was a problem hiding this comment.
When using #[cfg(not(test))], tests were compiling and running successfully, but non-test builds were failing. This change makes sure type checks take place in both test mode and non-test mode.
|
I won't have time to finish this one, at least not in the near future. If someone else could pick up where I left off it would be much appreciated. Some background: These changes make use of the new trait, The the struct this pr introduces is called The implementation is complete except for the public key verification bit. I've left one rustc error behind to indicate the main unfinished part of this pr. Just run Work so far is on the client (SlateSender). The server shouldn't require any code; just run the foreign api on https and note the public key used. Once AuthenticatedHttpsSlateSender is implemented, authenticated sends can be added as a method to the wallet's send command. Feel free to ask me questions. |
|
Going to leave this open for now as I think it's a good idea, but it's likely going to need discussion with the wallet subteam and possibly an RFC. I'm busy with other things at the moment, but if anyone wants to pick this up now help would be welcome. |
yeastplume
added
good first issue
|
Going to close for now, as the focus is on TOR at the moment which handles the encryption without needing to provide extra keys to senders. If somebody's interested in looking at this further, please feel free to propose via RFC. |
Adds a way to send grin to a server authenticated by its TLS public key. PKI is not required or used. The public key must already be known by the sender.