fixfees on grin-wallet #526
Conversation
There was a problem hiding this comment.
This PR increases the fee of a tx, will this cause compatibility issues with older wallets? If an older wallet initiates a tx with a newer wallet, will the newer wallet deny it because the fee is too low?
Other than this issue (and the Cargo files) I think the PR looks good.
util/Cargo.toml
Outdated
| # grin_util = { path = "../../grin/util"} | ||
| # grin_api = { path = "../../grin/api"} | ||
| # grin_store = { path = "../../grin/store"} | ||
| grin_core = { git = "https://github.com/tromp/grin", branch = "fixfees" } |
There was a problem hiding this comment.
We need to revert this file once the fixfees PR on grin is merged. Same with the Cargo.lock file
There was a problem hiding this comment.
what you point out is not just a wallet issue. nodes running new code will not relay txs paying old fees.
There was a problem hiding this comment.
Upon further investigation there is no compatibility issue between upgraded and non-upgraded wallets, since the receiving side does not actually check the fee.
👍 from me once we fix the Cargo files after merging mimblewimble/grin#3481.
Note: MWC implementation is more simple, because sync with updated node was done before and many issues was addressed at that time. Also, the default base fee is not changed because for MWC we don't change the calculation fee formula.
Complements the fixfees PR at mimblewimble/grin#3481
Still needs some doc tests fixed, which requires some assistance from @yeastplume