Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need support for rewriting grin-server.toml file #3540

Closed
tromp opened this issue Jan 6, 2021 · 1 comment · Fixed by #3634
Closed

Need support for rewriting grin-server.toml file #3540

tromp opened this issue Jan 6, 2021 · 1 comment · Fixed by #3634

Comments

@tromp
Copy link
Contributor

tromp commented Jan 6, 2021

The fixfees RFC lowered the accept_fee_base default from 1_000_000 to 500_000, but most nodes
have the 1_000_000 setting in the grin-server.toml configuration file, which would incorrectly override the new 500_000 default.

This resulted in the ugly fight-override fix at #3539

To get rid of that exception code, we would like to be able to rewrite the grin-server.toml file
in order to update obsolete defaults.

@trevyn
Copy link
Contributor

trevyn commented Mar 20, 2021

For reference, I started working on this over at trevyn/grin/commits/trevyn-fix-accept-fee-base. I'm not entirely happy with the approach yet, but I did get it working. I've put this on the back burner and may pick it up again, but until then, I wanted to inform anyone who might find this information to be useful. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants