Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

override old accept_fee_base setting of 1000000 to new default 500000 #3539

Merged
merged 3 commits into from
Jan 6, 2021
Merged

override old accept_fee_base setting of 1000000 to new default 500000 #3539

merged 3 commits into from
Jan 6, 2021

Conversation

tromp
Copy link
Contributor

@tromp tromp commented Jan 6, 2021

override old accept_fee_base setting of 1000000 to new default 500000
so node operators needn't update their grin-server.toml in order to respect the new fee regime.

@tromp tromp mentioned this pull request Jan 6, 2021
Closed
antiochp
antiochp approved these changes Jan 6, 2021
View reviewed changes
Copy link
Member

@antiochp antiochp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
As discussed - its not elegant but it avoids needing to update config network wide.
To be revisited once we have a robust solution for writing/rewriting config during node upgrades.

@antiochp antiochp merged commit 4877f30 into mimblewimble:master Jan 6, 2021
antiochp pushed a commit to antiochp/grin that referenced this pull request Jan 6, 2021
@tromp @antiochp
override old accept_fee_base setting of 1000000 to new default 500000 (…
7e64849 
…mimblewimble#3539)

* override old accept_fee_base setting of 1000000 to new default 500000

* document exceptional accept_fee_base behaviour in grin-server.toml

* document more accurately
@antiochp antiochp mentioned this pull request Jan 6, 2021
Merged
antiochp added a commit that referenced this pull request Jan 6, 2021
@antiochp @tromp
override old accept_fee_base setting of 1000000 to new default 500000 (…
d5bd93f 
…#3539) (#3541)

* override old accept_fee_base setting of 1000000 to new default 500000

* document exceptional accept_fee_base behaviour in grin-server.toml

* document more accurately

Co-authored-by: John Tromp <john.tromp@gmail.com>
@antiochp antiochp mentioned this pull request May 6, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antiochp antiochp antiochp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tromp @antiochp