a bit refactoring on wallet controller for issue_send_tx #2280
+15
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
garyyu
commented
Jan 3, 2019
garyyu
commented
- a little bit refactoring based on fix keybase slate return #2278
- leave a TODO item there for the service hanging issue when using keybase (according to @mcdallas 's concern: LibTx Error when finalizing a slate returned by issue_send_tx using keybase #2266 (comment))
- clean 2 minor build warnings
hashmap
reviewed
Jan 3, 2019
src/bin/cmd/wallet.rs
Outdated
| @@ -14,7 +14,9 @@ | |||
|
|
|||
| use crate::cmd::wallet_args; | |||
| use crate::config::GlobalWalletConfig; | |||
| /* Turned off for the time being | |||
There was a problem hiding this comment.
😄 I just copy all those web wallet related switching off.
Ok to remove it, since just one use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.