-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle rpc requests unwrap crash in stratumserver.rs #2446
Handle rpc requests unwrap crash in stratumserver.rs #2446
Conversation
Thanks for fixing the bug, but got another 'panic' today while using the executable built from the new code.
|
One more 'panic': 20190123 17:48:37.847 ERROR grin_util::logger - |
Why do you want to merge it after tokio-stratum? |
@hashmap not sure who the question is for? I'm ok merging this now. |
@ignopeverell it was a question to @sesam reg the first line in pr description. I'm ok too, however I feel like we are kicking the can down the road, I'd prefer to understand why we can't find stats for the worker. |
There is a lot wrong about the stratum server right now. So we can:
I looks like we're doing 3 already, so I don't really see the point in 2. And until 3 is ready, then 1 makes sense. No? |
Merge after https://github.com/mimblewimble/grin/pull/2468/files
Fixes #2421
Together with hashmaps the_message.clear fix, this solves the catastrophic #2421 that made stratum servers to become unreachable in a hard to detect manner.
We need additional issues about testing that should be added.