Fallback to building empty block to mine (if txpool is somehow in invalid state) #2451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
servers/src/mining/mine_block.rs
Outdated
| let txs = tx_pool | ||
| .read() | ||
| .prepare_mineable_transactions() | ||
| .unwrap_or(vec![]); |
There was a problem hiding this comment.
How about adding a big and loud error message to the logs here?
There was a problem hiding this comment.
Oh and that will suppress the error itself, right?
|
I thought about clearing/resetting the pool but it feels like this would be potentially worse than leaving it alone. And if we have a situation where someone was able to construct a tx that triggered this then they have the ability to drop existing txs on the floor with this. Agree on the loud logging - let me update the error handling to do this. |
antiochp
force-pushed
the
fallback_to_empty_block
branch
from
e0680b2 to
61fe141
Compare
|
Now logging loudly if we fail to prepare txs for mining (and we fallback to mining empty block). |
ignopeverell
approved these changes
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beam issue got me paranoid about our txpool...
Adding some error handling and fallback behavior to the
build_blockfn inmine_block.We call
prepare_mineable_transactions()on the txpool and there exists the possibility of this raising an error and failing to prepare some valid transactions.This PR handles an error here by falling back to an empty vec of txs which will result in the building of an empty block.
This would be far preferable to jamming a mining node up with an invalid txpool and no way to recover.
Note: The txpool is "reconciled" against chain state every time a new block is accepted, so even if we do end up with an invalid txpool, it should resolve itself against current chain state as soon as the next block is found.
This PR will not change this existing behavior, but should give the mining node a chance to mine an empty block.