Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default to sane value for missing owner_api_listen_port #2484

Merged
merged 3 commits into from
Jan 30, 2019
Merged

default to sane value for missing owner_api_listen_port #2484

merged 3 commits into from
Jan 30, 2019

Conversation

antiochp
Copy link
Member

@antiochp antiochp commented Jan 28, 2019 •
edited
Loading

Resolves #2482.

Safely default to 3420 if owner_api_listen_port is not explicitly set in grin-wallet.toml

  • Tested grin wallet info with and without owner_api_listen_port set.
  • Tested grin wallet init generates a new grin-wallet.toml successfully (confirmed default is set correctly).

@antiochp antiochp added the bug label Jan 28, 2019
@antiochp antiochp added this to the 1.0.1 milestone Jan 28, 2019
@antiochp antiochp requested a review from yeastplume January 28, 2019 15:02
garyyu
garyyu reviewed Jan 28, 2019
View reviewed changes
wallet/src/types.rs Outdated Show resolved Hide resolved
@garyyu
Copy link
Contributor

garyyu commented Jan 28, 2019

and please don't forget config/src/comments.rs for this new config item.

@antiochp
add comment for owner_api_listen_port
72aedb5 
and cleanup previous comment
@antiochp
Copy link
Member Author

Generated config file looks like this -

#path of TLS certificate file, self-signed certificates are not supported
#tls_certificate_file = ""
#private key for the TLS certificate
#tls_certificate_key = ""

#port for wallet listener
api_listen_port = 3415

#port for wallet owner api
owner_api_listen_port = 3420

@ignopeverell ignopeverell merged commit 507da6a into mimblewimble:master Jan 30, 2019
bitgrin pushed a commit to bitgrin/bitgrin that referenced this pull request Feb 15, 2019
@antiochp
default to sane value for missing owner_api_listen_port (mimblewimbl…
4cb6092 
…e#2484)

* default to sane value for missing owner_api_listen_port

* add comment for owner_api_listen_port
and cleanup previous comment

* get rid of TODO
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyyu garyyu garyyu left review comments

@yeastplume yeastplume Awaiting requested review from yeastplume

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@antiochp @garyyu @ignopeverell